Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add declaration type in ESMExport #227

Merged
merged 4 commits into from
Feb 21, 2024
Merged

feat: add declaration type in ESMExport #227

merged 4 commits into from
Feb 21, 2024

Conversation

tmg0
Copy link
Contributor

@tmg0 tmg0 commented Feb 8, 2024

πŸ”— Linked issue

Issue: #226

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add optional field declarationType in ESMExport. If export type is declaration, this field should be a string value like interface type enum const or function.
This approach can solve the issue of not being able to distinguish what specific type 'declaration' is.
Issue: #226
Unimport issue: #318
Unimport pull request: fix re-export ts enum type

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 5c8f76b into unjs:main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants